Patrick-Leigh
Inkling
You do have a lot of interesting ideas for your Elves and most of the points I would have made regarding them have already been made by other people, so the only insight I have to offer is from what I'm doing with my Elves - they don't all get along with each other very well and some of them (primarily the Sun Elves, aka Solarians) like to consider themselves the only "true" Elves. As a result, they use inbreeding to try to "preserve" their "purity," resulting in Elves who are basically like the Hapsburgs in terms of how inbred they are. So, what I wonder is if any of your Elves are like that - thinking that they're better than all the other Elves and trying to reacquire their former magic through selective breeding.