I don't see editing as a single thing but rather as a conglomeration of things, each of which has its own stopping points.
Consider plot, setting, character, and theme. Now consider correction versus improvement. Add in grammar, spelling, diction. Don't forget pacing. Or clarity, and consistency. I get tired just looking at the list, which is not comprehensive.
Where to stop? Heck, where to *start*?
I'd start with those first four, and I'd focus on corrections and improvements. Start with the easiest, which would be corrections. I know I said gray eyes, but now I want blue (shout out to Summoner Geeks). Are there mistakes in the setting, in characters (behaviors as well as appearance as well as story knowledge)? This is where consistency and clarity apply. A common example would be how a character speaks. Is this consistent through the story? All this is sometimes called the bones of the story. If there are problems at this level, they will undercut everything that's built on top of them. Plot corrections is mostly plot holes but can also be contradictions or events evolving out of logical order.
If the bones are solid, then you can start to look at improvements. Should a character be more developed, or developed earlier (or later)? Does the setting need work; for example, are there too many conversations in the white room? Is there room to make each character's voice more distinctive? Or more recognizable? Improving the plot often means improving the pacing.
Now the fun part. After you've made all your improvements, you have to do the corrections step again, because you've almost certainly introduced continuity errors.
The examples in the OP were more focused on diction, or what is sometimes called style. Is the description vivid, clear, and compelling? Improvements (and corrections) here can happen most any time, but I suggest it get done while you are rewriting that character's dialog, or this description of the setting. Since you are already rewriting, you can pay attention to the writing itself.
Whew. Now back to the question. If I'm reading the manuscript for consistency and clarity in dialog, I'm making notes as I go. I try not to make changes because I'm too easily distracted. The next pass is for making those changes. This is an attempt to separate the editor function from the writer function. Other passes for setting and plot, but honestly I very often wind up making notes on every aspect as I go. Anyway, as long as there's nothing huge like "two more chapters here", then I go through making the changes and that's done.
To put it another way: one editorial pass, one revision pass. That's the aim. It's rarely that tidy, but it's good to have goals, or so say the players. Once that's done, there could be another round or not. Depends largely on how extensive those first revisions were.
But there is a goal. The goal is to get the manuscript to a point where I'm not embarrassed to offer the story to beta readers. It doesn't have to be great, but it has to be to the point where I feel like I wouldn't be wasting their time. This is subjective and you won't have an unambiguous feeling on your first book. It will take a few.
The beta readers (or a hired editor) will present me with another round of revisions. See above.
Then it's one or two more passes for proofreading. Here is where spellcheck and grammar tools step forward. At this point, I'm not really revising any more. In fact, I regard the manuscript as frozen, except for spelling errors and the like.
Then it's off to the wonderful world of formatting! *shudder*
Consider plot, setting, character, and theme. Now consider correction versus improvement. Add in grammar, spelling, diction. Don't forget pacing. Or clarity, and consistency. I get tired just looking at the list, which is not comprehensive.
Where to stop? Heck, where to *start*?
I'd start with those first four, and I'd focus on corrections and improvements. Start with the easiest, which would be corrections. I know I said gray eyes, but now I want blue (shout out to Summoner Geeks). Are there mistakes in the setting, in characters (behaviors as well as appearance as well as story knowledge)? This is where consistency and clarity apply. A common example would be how a character speaks. Is this consistent through the story? All this is sometimes called the bones of the story. If there are problems at this level, they will undercut everything that's built on top of them. Plot corrections is mostly plot holes but can also be contradictions or events evolving out of logical order.
If the bones are solid, then you can start to look at improvements. Should a character be more developed, or developed earlier (or later)? Does the setting need work; for example, are there too many conversations in the white room? Is there room to make each character's voice more distinctive? Or more recognizable? Improving the plot often means improving the pacing.
Now the fun part. After you've made all your improvements, you have to do the corrections step again, because you've almost certainly introduced continuity errors.
The examples in the OP were more focused on diction, or what is sometimes called style. Is the description vivid, clear, and compelling? Improvements (and corrections) here can happen most any time, but I suggest it get done while you are rewriting that character's dialog, or this description of the setting. Since you are already rewriting, you can pay attention to the writing itself.
Whew. Now back to the question. If I'm reading the manuscript for consistency and clarity in dialog, I'm making notes as I go. I try not to make changes because I'm too easily distracted. The next pass is for making those changes. This is an attempt to separate the editor function from the writer function. Other passes for setting and plot, but honestly I very often wind up making notes on every aspect as I go. Anyway, as long as there's nothing huge like "two more chapters here", then I go through making the changes and that's done.
To put it another way: one editorial pass, one revision pass. That's the aim. It's rarely that tidy, but it's good to have goals, or so say the players. Once that's done, there could be another round or not. Depends largely on how extensive those first revisions were.
But there is a goal. The goal is to get the manuscript to a point where I'm not embarrassed to offer the story to beta readers. It doesn't have to be great, but it has to be to the point where I feel like I wouldn't be wasting their time. This is subjective and you won't have an unambiguous feeling on your first book. It will take a few.
The beta readers (or a hired editor) will present me with another round of revisions. See above.
Then it's one or two more passes for proofreading. Here is where spellcheck and grammar tools step forward. At this point, I'm not really revising any more. In fact, I regard the manuscript as frozen, except for spelling errors and the like.
Then it's off to the wonderful world of formatting! *shudder*